linux-kernel - Re: [BUG bisected]: apei_hest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Feb 2013 22:00:35 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Toshi Kani <toshi.kani@...com>,
	Huang Ying <ying.huang@...el.com>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [BUG bisected]: apei_hest_parse explosion

On Friday, February 22, 2013 03:39:44 PM Thomas Gleixner wrote:
> On Fri, 22 Feb 2013, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > Subject: ACPI / APEI: Fix crash in apei_hest_parse() for acpi=off
> > 
> > After commit 92ef2a2 (ACPI: Change the ordering of PCI root bridge
> > driver registrarion), acpi_hest_init() is never called for acpi=off
> > (acpi_disabled), so hest_disable is not set, but hest_tab is NULL,
> > which causes apei_hest_parse() to crash when it is called from
> > aer_acpi_firmware_first().
> > 
> > Fix that by making apei_hest_parse() check if hest_tab is not NULL
> > in addition to checking hest_disable.  Also remove the now useless
> > acpi_disabled check from apei_hest_parse().
> > 
> > Reported-by: Thomas Gleixner <tglx@...utronix.de>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Tested-by: Thomas Gleixner <tglx@...utronix.de>

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/