linux-kernel - Re: [PATCH] lib: devres: Fix misplaced #endif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Feb 2013 11:13:14 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Andrew Morton' <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, 'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH] lib: devres: Fix misplaced #endif

On Saturday, February 23, 2013 6:44 AM, Andrew Morton wrote:
> 
> On Fri, 22 Feb 2013 14:39:40 +0900
> Jingoo Han <jg1.han@...sung.com> wrote:
> 
> > A misplaced #endif causes link errors related to pcim_*() functions.
> >
> > --- a/lib/devres.c
> > +++ b/lib/devres.c
> > @@ -227,6 +227,7 @@ void devm_ioport_unmap(struct device *dev, void __iomem *addr)
> >  			       devm_ioport_map_match, (void *)addr));
> >  }
> >  EXPORT_SYMBOL(devm_ioport_unmap);
> > +#endif /* CONFIG_HAS_IOPORT */
> >
> >  #ifdef CONFIG_PCI
> >  /*
> > @@ -432,4 +433,3 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask)
> >  }
> >  EXPORT_SYMBOL(pcim_iounmap_regions);
> >  #endif /* CONFIG_PCI */
> > -#endif /* CONFIG_HAS_IOPORT */
> 
> More details needed, please.  This code is pretty old and it's
> surprising that errors are popping up now.

OK, I will add more detailed commit message.
Thank you.

Best regards,
Jingoo Han



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/