linux-kernel - Re: [PATCH 1/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Feb 2013 14:48:20 -0700
From:	Shuah Khan <shuah@...hp.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>, joro@...tes.org
Cc:	dhowells@...hat.com, paulmck@...ux.vnet.ibm.com,
	linasvepstas@...il.com, davej@...hat.com, tglx@...utronix.de,
	mtk.manpages@...il.com, iommu@...ts.linux-foundation.org,
	LKML <linux-kernel@...r.kernel.org>, linux-pci@...r.kernel.org,
	shemminger@...tta.com, jiang.liu@...wei.com, wangyijing@...wei.com,
	shuahkhan@...il.com
Subject: Re: [PATCH 1/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to
 return bus number and device id

On Mon, 2013-02-25 at 14:53 -0700, Shuah Khan wrote:
> On Mon, 2013-02-25 at 14:23 -0700, Bjorn Helgaas wrote:
> > On Mon, Feb 25, 2013 at 9:37 AM, Shuah Khan <shuah.khan@...com> wrote:
> > > On Wed, 2013-02-20 at 18:19 -0700, Bjorn Helgaas wrote:
> > >> On Mon, Feb 11, 2013 at 4:00 PM, Shuah Khan <shuah.khan@...com> wrote:

> > 
> > It's not nice and consistent, but it does follow the simple rule of
> > "don't expose things to user-space unnecessarily."  We might want to
> > add a comment to keep somebody from cleaning it up later.
> 
> ok. Will resend patches adding the new defines to linux/pci.h and
> renaming PCI_BUS() to PCI_BUS_NR() or PCI_BUS_NUM() like you suggested.
> 
> Thanks,
> -- Shuah
> 

Bjorn/Joerg,

I added PCI_BUS_NUM() amd PCI_DEVID() to linux/pci.h. Please note that
changing PCI_BUS() to PCI_BUS_NUM() required additional changes to AMD
IOMMU source files and aer driver. Essentially in addition to removing
local PCI_BUS() define, PCI_BUS() usages are changed to PCI_BUS_NUM(). I
am resending the patches.

Thanks,
-- Shuah


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/