linux-kernel - Re: [PATCH 1/1] arm: remove extra semicolon in if statement

Open Source and information security mailing list archives

Date:	Fri, 1 Mar 2013 09:15:08 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:	Vinicius Tinti <viniciustinti@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Will Deacon <Will.Deacon@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/1] arm: remove extra semicolon in if statement

On Fri, Mar 01, 2013 at 08:36:24AM +0000, Uwe Kleine-König wrote:
> Hello,
> 
> On Fri, Mar 01, 2013 at 01:25:52AM -0300, Vinicius Tinti wrote:
> > Remove extra semicolon in perf_event.c if statement.
> The commit log sounds like a style fix, but your patch introduces a
> semantical change. I suspect this patch fixes a real bug, you should
> point that out here.
> 
> Best regards
> Uwe

It does fix a real bug, but Will already has a fix [1]. It's in rmk's patch
tracking system as 7664/1.

Thanks,
Mark.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/151564.html

> > 
> > Signed-off-by: Vinicius Tinti <viniciustinti@...il.com>
> > ---
> >  arch/arm/kernel/perf_event.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
> > index 31e0eb3..a892067 100644
> > --- a/arch/arm/kernel/perf_event.c
> > +++ b/arch/arm/kernel/perf_event.c
> > @@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
> >  	}
> >  
> >  	if (event->group_leader != event) {
> > -		if (validate_group(event) != 0);
> > +		if (validate_group(event) != 0)
> >  			return -EINVAL;
> >  	}
> >  
> > -- 
> > 1.7.9.5
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@...ts.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> > 
> 
> -- 
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives