linux-kernel - Re: [PATCH 10/30] staging: sync: Export sync API symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Feb 2013 18:00:08 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	John Stultz <john.stultz@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Erik Gilling <konkers@...roid.com>,
	Maarten Lankhorst <maarten.lankhorst@...onical.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Rob Clark <robclark@...il.com>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	dri-devel@...ts.freedesktop.org,
	Android Kernel Team <kernel-team@...roid.com>
Subject: Re: [PATCH 10/30] staging: sync: Export sync API symbols

On Thu, Feb 28, 2013 at 04:43:06PM -0800, John Stultz wrote:
> From: Erik Gilling <konkers@...roid.com>
> 
> This is needed to allow modules to link against the sync subsystem
> 
> Cc: Maarten Lankhorst <maarten.lankhorst@...onical.com>
> Cc: Erik Gilling <konkers@...roid.com>
> Cc: Daniel Vetter <daniel.vetter@...ll.ch>
> Cc: Rob Clark <robclark@...il.com>
> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> Cc: Greg KH <gregkh@...uxfoundation.org>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: Android Kernel Team <kernel-team@...roid.com>
> Signed-off-by: Erik Gilling <konkers@...roid.com>
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> ---
>  drivers/staging/android/sync.c |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
> index 54f84d9..6739a84 100644
> --- a/drivers/staging/android/sync.c
> +++ b/drivers/staging/android/sync.c
> @@ -15,6 +15,7 @@
>   */
>  
>  #include <linux/debugfs.h>
> +#include <linux/export.h>
>  #include <linux/file.h>
>  #include <linux/fs.h>
>  #include <linux/kernel.h>
> @@ -64,6 +65,7 @@ struct sync_timeline *sync_timeline_create(const struct sync_timeline_ops *ops,
>  
>  	return obj;
>  }
> +EXPORT_SYMBOL(sync_timeline_create);

As these are now global, should they be a bit more "specific"?  "sync_"
seems pretty broad.

Also, EXPORT_SYMBOL_GPL() perhaps?

And who is using these exports?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/