[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 02 Mar 2013 22:26:22 +0000
From: Grant Likely <grant.likely@...retlab.ca>
To: Boojin Kim <boojin.kim@...sung.com>, linux-kernel@...r.kernel.org,
linux-samsung-soc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
spi-devel-general@...ts.sourceforge.net,
alsa-devel@...a-project.org
Cc: 'Vinod Koul' <vinod.koul@...el.com>, 'Dan Williams' <djbw@...com>,
'Russell King' <linux@....linux.org.uk>,
'Kukjin Kim' <kgene.kim@...sung.com>,
'Mark Brown' <broonie@...nsource.wolfsonmicro.com>,
'Rob Herring' <rob.herring@...xeda.com>,
'Sangbeom Kim' <sbkim73@...sung.com>
Subject: Re: [PATCH v2 3/4] spi: s3c64xx: add dma maxburst size initialization
On Fri, 22 Feb 2013 17:09:18 +0900, Boojin Kim <boojin.kim@...sung.com> wrote:
> This patch adds dma maxburst size initialization.
> The maxburst should be set by MODE_CFGn.DMA_TYPE,
> because the pl330 dma driver supports burst mode.
>
> Signed-off-by: Hyeonkook Kim <hk619.kim@...sung.com>
Hello Hyeonkook,
I applied this patch but then discovered that it relys on the previous
patches that you've posted. When patched depend on each other like this
please post them as a series with [PATCH x/4] in the subject line.
'git send-email' will format this correctly for you.
g.
> ---
> drivers/spi/spi-s3c64xx.c | 18 ++++++++++++++++++
> 1 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index e862ab8..5e6cafe 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -287,10 +287,20 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma,
> struct s3c64xx_spi_driver_data *sdd;
> struct samsung_dma_prep info;
> struct samsung_dma_config config;
> + void __iomem *regs;
> + unsigned int mode_cfg;
>
> if (dma->direction == DMA_DEV_TO_MEM) {
> sdd = container_of((void *)dma,
> struct s3c64xx_spi_driver_data, rx_dma);
> +
> + regs = sdd->regs;
> + mode_cfg = readl(regs + S3C64XX_SPI_MODE_CFG);
> + if (mode_cfg & S3C64XX_SPI_MODE_4BURST)
> + config.maxburst = 4;
> + else
> + config.maxburst = 1;
> +
> config.direction = sdd->rx_dma.direction;
> config.fifo = sdd->sfr_start + S3C64XX_SPI_RX_DATA;
> config.width = sdd->cur_bpw / 8;
> @@ -298,6 +308,14 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma,
> } else {
> sdd = container_of((void *)dma,
> struct s3c64xx_spi_driver_data, tx_dma);
> +
> + regs = sdd->regs;
> + mode_cfg = readl(regs + S3C64XX_SPI_MODE_CFG);
> + if (mode_cfg & S3C64XX_SPI_MODE_4BURST)
> + config.maxburst = 4;
> + else
> + config.maxburst = 1;
> +
> config.direction = sdd->tx_dma.direction;
> config.fifo = sdd->sfr_start + S3C64XX_SPI_TX_DATA;
> config.width = sdd->cur_bpw / 8;
> --
> 1.7.5.4
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists