linux-kernel - Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 02 Mar 2013 09:18:36 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Peter Tyser <ptyser@...-inc.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

On Wed, 27 Feb 2013 17:25:15 +0200, Mika Westerberg <mika.westerberg@...ux.intel.com> wrote:
> ichx_gpio_check_available() returns either 0 or -ENXIO depending on whether
> the given GPIO is available or not. However, callers of this function treat
> the return value as boolean:
> 
> 	...
> 	if (!ichx_gpio_check_available(gpio, nr))
> 		return -ENXIO;
> 
> which erroneusly fails when the GPIO is available and not vice versa.
> 
> Fix this by making the function return boolean as expected by the callers.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Applied, thanks.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/