linux-kernel - Re: [PATCH] md: use set_bit_le and clear_bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 4 Mar 2013 11:58:21 +1100
From:	NeilBrown <neilb@...e.de>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	linux-raid@...r.kernel.org
Subject: Re: [PATCH] md: use set_bit_le and clear_bit_le

On Sat,  2 Mar 2013 23:35:57 +0900 Akinobu Mita <akinobu.mita@...il.com>
wrote:

> The value returned by test_and_set_bit_le() drivers/md/bitmap.c is not used.
> So just use set_bit_le(). The same goes for test_and_clear_bit_le().
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> Cc: Neil Brown <neilb@...e.de>
> Cc: linux-raid@...r.kernel.org
> ---
>  drivers/md/bitmap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 4fd9d6a..5a2c754 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -846,7 +846,7 @@ static void bitmap_file_set_bit(struct bitmap *bitmap, sector_t block)
>  	if (test_bit(BITMAP_HOSTENDIAN, &bitmap->flags))
>  		set_bit(bit, kaddr);
>  	else
> -		test_and_set_bit_le(bit, kaddr);
> +		set_bit_le(bit, kaddr);
>  	kunmap_atomic(kaddr);
>  	pr_debug("set file bit %lu page %lu\n", bit, page->index);
>  	/* record page number so it gets flushed to disk when unplug occurs */
> @@ -868,7 +868,7 @@ static void bitmap_file_clear_bit(struct bitmap *bitmap, sector_t block)
>  	if (test_bit(BITMAP_HOSTENDIAN, &bitmap->flags))
>  		clear_bit(bit, paddr);
>  	else
> -		test_and_clear_bit_le(bit, paddr);
> +		clear_bit_le(bit, paddr);
>  	kunmap_atomic(paddr);
>  	if (!test_page_attr(bitmap, page->index, BITMAP_PAGE_NEEDWRITE)) {
>  		set_page_attr(bitmap, page->index, BITMAP_PAGE_PENDING);

applied, thanks.

NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)