linux-kernel - Re: [PATCH 1/1] drivers/misc: Add Altera System ID driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Mar 2013 11:44:30 +0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Ley Foon Tan <lftan@...era.com>, Rob Landley <rob@...dley.net>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers/misc: Add Altera System ID driver

On Mon, Mar 04, 2013 at 03:32:19AM +0000, Arnd Bergmann wrote:
> On Monday 04 March 2013, Ley Foon Tan wrote:
> > This patch is to add Altera System ID driver.
> > User can obtain the system ID and timestamp of the system by
> > reading the sysfs entry.
> > 
> > Usage:
> > cat /sys/bus/platform/devices/[addr].sysid/sysid/id
> > cat /sys/bus/platform/devices/[addr].sysid/sysid/timestamp
> > 
> > Signed-off-by: Ley Foon Tan <lftan@...era.com>
> 
> All sysfs files need documentation in Documentation/ABI/.
> 
> This driver looks like it should instead be using the infrastructure we
> have for identifying an SoC in drivers/base/soc.c, which is currently
> only used by the ARM u8500 platform but was introduced as a generic
> interface for this a while ago.

I agree, this shouldn't be a one-off sysfs file.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/