linux-kernel - Re: [PATCH V2 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Mar 2013 14:21:53 +0800
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	amit kachhap <amit.kachhap@...il.com>
Cc:	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, kgene.kim@...sung.com,
	Thomas Abraham <thomas.abraham@...aro.org>,
	cpufreq@...r.kernel.org, Inderpal Singh <inderpal.singh@...aro.org>
Subject: Re: [PATCH V2 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

On 6 March 2013 13:35, amit kachhap <amit.kachhap@...il.com> wrote:
> On Tue, Mar 5, 2013 at 6:48 AM, Viresh Kumar <viresh.kumar@...aro.org> wrote:

>>> +static void exynos_cpufreq_work(struct work_struct *work)
>>> +{
>>> +       unsigned int cur_pstate, index;
>>> +       struct cpufreq_policy *policy = cpufreq_cpu_get(0); /* boot CPU */
>>> +       struct cpufreq_frequency_table *freq_table = dvfs_info->freq_table;
>>> +
>>> +       if (policy == NULL)
>>> +               goto skip_work;
>>
>> How can that be true? And if it can be, you will miss POSTCHANGE notifications
>> too.
> This skip of POSTCHANGE notifications is needed in one case where
> bootup frequency does not match with any elements of cpufreq table and
> hence I simply assign the highest frequency. Also cpufreq driver is
> not registered at this point.

I will keep a variable for that then, otherwise its misleading... So keep a
variable like cpufreq_enabled for it and set it to 1 as soon as this first
interrupt is gone... keep it in unlikely() too.

>>> +       dvfs_info = kzalloc(sizeof(struct exynos_dvfs_data), GFP_KERNEL);
>>
>> sizeof(*dvfs_info) ??
> Isn't both same?

You need to read Documentation/CodingStyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/