linux-kernel - RE: [PATCH] x86: fix idle notifier not being called in CONFIG_X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Mar 2013 10:20:33 +0000
From:	"Mansoor, Illyas" <illyas.mansoor@...el.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Linux PM <linux-pm@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, X86 <x86@...nel.org>,
	Len Brown <lenb@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Matthew Garrett <matthew.garrett@...ula.com>,
	Tejun Heo <tj@...nel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	"Rudramuni, Vishwesh M" <vishwesh.m.rudramuni@...el.com>,
	"richard@....at" <richard@....at>,
	"josh@...htriplett.org" <josh@...htriplett.org>,
	"Kumar P, Mahesh" <mahesh.kumar.p@...el.com>,
	"Sil, Dyut K" <dyut.k.sil@...el.com>
Subject: RE: [PATCH] x86: fix idle notifier not being called in CONFIG_X86_32

> * Illyas Mansoor <illyas.mansoor@...el.com> wrote:
> 
> > Idle notifier not registered if CONFIG_X86_32 is defined, those
> > callbacks are empty for X86_32 platform.
> >
> > ifdef CONFIG_X86_64
> >  void enter_idle(void);
> >  void exit_idle(void);
> > else
> > static inline void enter_idle(void) { } static inline void
> > exit_idle(void) { } static inline void __exit_idle(void) { } endif
> >
> > Make this work on X86_32 platforms by
> > removing the restriction for X86_64
> 
> What will they be used for?

It's being used by interactive governor, and since the idle notifications are
not received
It breaks the governor functionality on X86_32 

Thanks,
-Illyas

Download attachment "smime.p7s" of type "application/pkcs7-signature" (7212 bytes)