linux-kernel - Re: [PATCH v3 5/5] timekeeping: utilize the suspend-nonstop clocksource to count suspended time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Mar 2013 15:15:49 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Feng Tang <feng.tang@...el.com>
cc:	John Stultz <john.stultz@...aro.org>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	x86@...nel.org, Len Brown <lenb@...nel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	linux-kernel@...r.kernel.org, gong.chen@...ux.intel.com
Subject: Re: [PATCH v3 5/5] timekeeping: utilize the suspend-nonstop clocksource
 to count suspended time

On Wed, 6 Mar 2013, Feng Tang wrote:

> There are some new processors whose TSC clocksource won't stop during
> suspend. Currently, after system resumes, kernel will use persistent
> clock or RTC to compensate the sleep time, but for those new types of
> clocksources, we could skip the special compensation from external
> sources, and just use current clocksource for time recounting.
> 
> This can solve some time drift bugs caused by some not-so-accurate or
> error-prone RTC devices.
> 
> The current way to count suspened time is first try to use the persistent
> clock, and then try the rtc if persistent clock can't be used. This
> patch will change the trying order to:
> 	suspend-nonstop clocksource -> persistent clock -> rtc
> 
> Signed-off-by: Feng Tang <feng.tang@...el.com>
> ---
>  kernel/time/timekeeping.c |   42 ++++++++++++++++++++++++++++++++++--------
>  1 file changed, 34 insertions(+), 8 deletions(-)
> 
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index 9a0bc98..bd7c27b 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -788,22 +788,48 @@ void timekeeping_inject_sleeptime(struct timespec *delta)
>  static void timekeeping_resume(void)
>  {
>  	struct timekeeper *tk = &timekeeper;
> +	struct clocksource *clock = tk->clock;
>  	unsigned long flags;
> -	struct timespec ts;
> +	struct timespec ts_new, ts_delta;
> +	cycle_t cycle_now, cycle_delta;
> +	s64 nsec;
>  
> -	read_persistent_clock(&ts);
> +	ts_delta.tv_sec = 0;
> +	read_persistent_clock(&ts_new);
>  
>  	clockevents_resume();
>  	clocksource_resume();
>  
>  	write_seqlock_irqsave(&tk->lock, flags);
>  
> -	if (timespec_compare(&ts, &timekeeping_suspend_time) > 0) {
> -		ts = timespec_sub(ts, timekeeping_suspend_time);
> -		__timekeeping_inject_sleeptime(tk, &ts);
> -	}
> -	/* re-base the last cycle value */
> -	tk->clock->cycle_last = tk->clock->read(tk->clock);
> +	/*
> +	 * After system resumes, we need to calculate the suspended time and
> +	 * compensate it for the OS time. There are 3 sources that could be
> +	 * used: Nonstop clocksource during suspend, persistent clock and rtc
> +	 * device.
> +	 *
> +	 * One specific platform may have 1 or 2 or all of them, and the
> +	 * preference will be:
> +	 *	suspend-nonstop clocksource -> persistent clock -> rtc
> +	 * The less preferred source will only be tried if there is no better
> +	 * usable source. The rtc part is handled separately in rtc core code.
> +	 */
> +	cycle_now = clock->read(clock);
> +	if ((clock->flags & CLOCK_SOURCE_SUSPEND_NONSTOP) &&
> +		cycle_now > clock->cycle_last) {
> +
> +		cycle_delta = (cycle_now - clock->cycle_last) & clock->mask;
> +		nsec = clocksource_cyc2ns(cycle_delta, clock->mult,
> +							clock->shift);
> +		ts_delta = ns_to_timespec(nsec);
> +	} else if (timespec_compare(&ts_new, &timekeeping_suspend_time) > 0)
> +		ts_delta = timespec_sub(ts_new, timekeeping_suspend_time);
> +
> +	if (ts_delta.tv_sec >= 1)
> +		__timekeeping_inject_sleeptime(tk, &ts_delta);

If the suspend time measured by the nonstop clocksource is 0.999 sec
then we throw it away and then let the RTC code inject inaccurate
sleep time? Brilliant design, really.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/