linux-kernel - Re: [PATCH] check for allocation failure in ioat_dma_self

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Mar 2013 09:57:27 +0800
From:	Andrew Cooks <acooks@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Dan Williams <djbw@...com>, Vinod Koul <vinod.koul@...el.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Jassi Brar <jassisinghbrar@...il.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] check for allocation failure in ioat_dma_self_test

On Mon, Mar 4, 2013 at 6:11 PM, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:
> On Mon, Mar 04, 2013 at 04:39:16PM +0800, Andrew Cooks wrote:
>> diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
>> index 1879a59..1f706c4 100644
>> --- a/drivers/dma/ioat/dma.c
>> +++ b/drivers/dma/ioat/dma.c
>> @@ -832,7 +832,18 @@ int ioat_dma_self_test(struct ioatdma_device *device)
>>       }
>>
>>       dma_src = dma_map_single(dev, src, IOAT_TEST_SIZE, DMA_TO_DEVICE);
>> +     err = dma_mapping_error(dev, dma_src);
>> +     if (err) {
>> +             dev_err(dev, "dma mapping failed: -%d\n", err);
>> +             goto free_resources;
>> +     }
>
> NAK.  Please take the time to check what the functions you're using return
> rather than assuming what they return.

I see. The same mistake occurs in a few other drivers. I'll rework and
resend this and if all goes well I'll clean up the others.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/