linux-kernel - Re: [PATCH] zcache/debug: compiler failure on PPC64.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 7 Mar 2013 09:31:58 +0800
From:	Greg KH <greg@...ah.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	sfr@...b.auug.org.au
Subject: Re: [PATCH] zcache/debug: compiler failure on PPC64.

On Wed, Mar 06, 2013 at 07:13:36PM -0500, Konrad Rzeszutek Wilk wrote:
> On PPC64 we get this:
> In file included from drivers/staging/zcache/debug.c:2:
> drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> drivers/staging/zcache/debug.h:16: error: implicit declaration of function 'BUG_ON'
> 
> This simple patch adds the appropiate header file to finish
> the compile.
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> ---
>  drivers/staging/zcache/debug.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/zcache/debug.h b/drivers/staging/zcache/debug.h
> index eef67db..0d9c6b4 100644
> --- a/drivers/staging/zcache/debug.h
> +++ b/drivers/staging/zcache/debug.h
> @@ -1,5 +1,6 @@
>  #ifdef CONFIG_ZCACHE_DEBUG
>  
> +#include <linux/bug.h>
>  /* we try to keep these statistics SMP-consistent */

Put the #include files at the top of the file.

Also, you didn't really test this on linux-next as you can't select this
option at the moment, I think you also want to fix that at the same
time, unless you really don't want anyone to ever select this option :)

Try it again?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/