linux-kernel - Re: [PATCH 07/33] nohz: Basic full dynticks interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Mar 2013 00:41:03 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Alessio Igor Bogani <abogani@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Metcalf <cmetcalf@...era.com>,
	Christoph Lameter <cl@...ux.com>,
	Geoff Levand <geoff@...radead.org>,
	Gilad Ben Yossef <gilad@...yossef.com>,
	Hakan Akkan <hakanakkan@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Li Zhong <zhong@...ux.vnet.ibm.com>,
	Namhyung Kim <namhyung.kim@....com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 07/33] nohz: Basic full dynticks interface

2013/2/20 Borislav Petkov <bp@...en8.de>:
> On Mon, Feb 11, 2013 at 03:35:29PM +0100, Borislav Petkov wrote:
>> > +/* Parse the boot-time nohz CPU list from the kernel parameters. */
>> > +static int __init tick_nohz_full_setup(char *str)
>> > +{
>> > +   alloc_bootmem_cpumask_var(&full_nohz_mask);
>> > +   have_full_nohz_mask = true;
>> > +   cpulist_parse(str, full_nohz_mask);
>>
>> Don't you want to check retval of cpulist_parse first here before
>> assigning have_full_nohz_mask and allocating cpumask var?
>>
>> We don't trust userspace, you know.
>>
>> > +   return 1;
>> > +}
>> > +__setup("full_nohz=", tick_nohz_full_setup);
>
> One more thing. AFAICT, full_nohz requires rcu_nocbs to pass in the same
> mask, right?

Right!

> Maybe tick_nohz_full_setup() could be made to call rcu_nocb_setup()
> without the need to pass "rcu_nocbs=" option on the cmd line; in the
> sense that if user supplies a full_nohz mask, she wants the same mask
> for rcu_nocbs...

Yeah that's probably something we want. (added to the TODO list)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/