linux-kernel - Re: [PATCH 17/31] workqueue: implement attribute-based unbound worker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Mar 2013 11:36:53 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, axboe@...nel.dk, jmoyer@...hat.com,
	zab@...hat.com
Subject: Re: [PATCH 17/31] workqueue: implement attribute-based unbound
 worker_pool management

On Sun, Mar 10, 2013 at 05:58:21AM -0700, Tejun Heo wrote:
> > > +	if (WARN_ON(pool->nr_workers != pool->nr_idle))
> > > +		return;
> > 
> > This can be false-negative. we should remove this WARN_ON().
> 
> How would the test fail spuriously?  Can you please elaborate?

I got it.  It'll be short by one if there's an active manager.
Removed.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/