linux-kernel - Re: [PATCH] drivers: thermal: cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Mar 2013 22:24:28 +0800
From:	Zhang Rui <rui.zhang@...el.com>
To:	Laurent Navet <laurent.navet@...il.com>
Cc:	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: thermal: cpu_cooling: fix checkpatch warning

On Tue, 2013-02-26 at 14:42 +0100, Laurent Navet wrote:
> - WARNING: Avoid CamelCase: <maskPtr>
> 
> Signed-off-by: Laurent Navet <laurent.navet@...il.com>
> ---
>  drivers/thermal/cpu_cooling.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 836828e..47b7d32 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -175,8 +175,8 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
>  				unsigned long cooling_state)
>  {
>  	unsigned int cpuid, clip_freq;
> -	struct cpumask *maskPtr = &cpufreq_device->allowed_cpus;
> -	unsigned int cpu = cpumask_any(maskPtr);
> +	struct cpumask *mask = &cpufreq_device->allowed_cpus;
> +	unsigned int cpu = cpumask_any(mask);
>  
> 
>  	/* Check if the old cooling action is same as new cooling action */
> @@ -191,7 +191,7 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
>  	cpufreq_device->cpufreq_val = clip_freq;
>  	notify_device = cpufreq_device;
>  
> -	for_each_cpu(cpuid, maskPtr) {
> +	for_each_cpu(cpuid, mask) {
>  		if (is_cpufreq_valid(cpuid))
>  			cpufreq_update_policy(cpuid);
>  	}
why not fix the code in cpufreq_get_max_state() as well, in one patch?

thanks,
rui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/