linux-kernel - Re: [PATCH v3] fat: editions to support fat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Mar 2013 00:01:35 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, abartlet@...ba.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Ravishankar N <ravi.n1@...sung.com>
Subject: Re: [PATCH v3] fat: editions to support fat_fallocate

Namjae Jeon <linkinjeon@...il.com> writes:

>> This choose ->release(). BTW, we would also be able to do this only
>> ->evict_inode(), although I'm not thinking yet which one is better.
>>
>> If you had conclusion, it would be nice to explain it.
> evict_inode() will be called only when we unlink the file or if inode
> is evicted from cache.
> As we discussed with you before, We considered preallocated blocks is
> discarded on all close file cases(unlink and muliple openning file).
> So we think it would be better to do this in ->release().

If so, probably, I didn't clear my opinion/suggestion, or misled
you. Sorry about it.

My opinion/suggestion is, "it should be before umount()".
I.e. fallocate() doesn't have any affect to FAT on clean state (clean
umount).

To clear my state, I don't have strong opinion about implementation yet.
For example, about ->release() or ->evict_inode().

So, if you had reason to use ->release() over "we discussed", it would
be good. (Or, if you still didn't have reasons, we would be better to
think about it)

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/