linux-kernel - Re: [PATCH v2] s390: use kcalloc instead of kmalloc and memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Mar 2013 08:07:15 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Stelian Nirlu <steliannirlu@...il.com>
Cc:	schwidefsky@...ibm.com, linux390@...ibm.com,
	linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
	penberg@...nel.org
Subject: Re: [PATCH v2] s390: use kcalloc instead of kmalloc and memset

On Mon, Mar 11, 2013 at 06:22:10PM +0200, Stelian Nirlu wrote:
> Signed-off-by: Stelian Nirlu <steliannirlu@...il.com>
> ---
>  arch/s390/net/bpf_jit_comp.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c
> index 0972e91..82f165f 100644
> --- a/arch/s390/net/bpf_jit_comp.c
> +++ b/arch/s390/net/bpf_jit_comp.c
> @@ -747,10 +747,9 @@ void bpf_jit_compile(struct sk_filter *fp)
> 
>  	if (!bpf_jit_enable)
>  		return;
> -	addrs = kmalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
> +	addrs = kcalloc(fp->len, sizeof(*addrs), GFP_KERNEL);
>  	if (addrs == NULL)
>  		return;
> -	memset(addrs, 0, fp->len * sizeof(*addrs));

Applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/