linux-kernel - Re: [PATCH 00/12] perf annotate: Add support for event group view (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Mar 2013 16:52:28 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>, Andi Kleen <andi@...stfloor.org>,
	Namhyung Kim <namhyung.kim@....com>,
	Pekka Enberg <penberg@...nel.org>
Subject: Re: [PATCH 00/12] perf annotate: Add support for event group view
 (v2)

Em Tue, Mar 12, 2013 at 12:21:27PM +0900, Namhyung Kim escreveu:
> On Mon, 11 Mar 2013 17:53:16 -0300, Arnaldo Carvalho de Melo wrote:
> > I need to go thru this more thoroughly, as at least one thing caught my
> > attention, in some cases ->nr_pcnt is used and in others
> > evsel->nr_members, do we need both?

> Probably not.  I was thought keeping an array and its length together is
> better.  But it's rather a waste to save the same information to every
> date structure so I move it to the struct annotate_browser->nr_events.
 
> For evsel->nr_members, current code sets it only for grouping is enabled
> so the individual events will have value of 0.  Also it's not pass the
> evsel to every function need it.  But if you think it should really be
> fixed that way I can make the change to pass and use evsel->nr_members.

This can be left for later, my point here is that we should try to avoid
the various UIs from diverging too much, i.e. the code for --gtk,
--stdio and --tui should be as close and using the same abstractions as
possible.
 
> Anyway, below is a fixed version that could survived my testing.

indeed, works, compared the output of --stdio --group with --tui --group
and it matches.

While looking at it I noticed that the stdio output wastes the initial
columns, at some point we may want to make the hist_entry lines match
the TUI ones, so that going back and forth on two xterm tabs shows no
differences.

Anyway, thanks, applied!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/