linux-kernel - Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Mar 2013 14:15:15 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Doug Anderson <dianders@...omium.org>
Cc:	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	lm-sensors@...sensors.org, devicetree-discuss@...ts.ozlabs.org,
	Jean Delvare <khali@...ux-fr.org>,
	Naveen Krishna <naveenkrishna.ch@...il.com>
Subject: Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor
 driver

On Wed, Mar 13, 2013 at 01:52:35PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Tue, Mar 12, 2013 at 9:08 PM, Naveen Krishna Chatradhi
> <ch.naveen@...sung.com> wrote:
> > This patch adds DT support to NTC driver to parse the
> > platform data.
> >
> > Also adds the support to work as an iio device.
> >
> > During the probe ntc driver gets the respective channels of ADC
> > and uses iio_raw_read calls to get the ADC converted value.
> >
> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@...sung.com>
> > ---
> > Changes since v3:
> > 1. Added a NULL check before iio_channel_release
> > 2. Modified a return statement
> >
> > Guenter Roeck, Its wonderful working with you. Thanks.
> >
> >  .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   29 ++++
> >  drivers/hwmon/Kconfig                              |    1 +
> >  drivers/hwmon/ntc_thermistor.c                     |  145 +++++++++++++++++---
> >  include/linux/platform_data/ntc_thermistor.h       |    8 +-
> >  4 files changed, 163 insertions(+), 20 deletions(-)
> 
> I haven't done a full review of this code, but it I built it in (along
> with other CLs to enable it on exynos5250-snow) and the thermistors
> are accessible and report reasonable values.
> 
> localhost hwmon # grep "" /sys/class/hwmon/*/device/temp1_input
> /sys/class/hwmon/hwmon0/device/temp1_input:37890
> /sys/class/hwmon/hwmon1/device/temp1_input:38393
> /sys/class/hwmon/hwmon2/device/temp1_input:37148
> /sys/class/hwmon/hwmon3/device/temp1_input:38059
> 
> Tested-by: Doug Anderson <dianders@...omium.org>
> 
Thanks!

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/