linux-kernel - Re: [RFC V1 0/8] Add a driver for somagic smi2021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 17 Mar 2013 21:01:58 +0100
From:	Jon Arne Jørgensen <jonarne@...arne.no>
To:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
Cc:	Jon Arne Jørgensen <jonarne@...arne.no>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	hverkuil@...all.nl, elezegarcia@...il.com
Subject: Re: [RFC V1 0/8] Add a driver for somagic smi2021

On Fri, Mar 15, 2013 at 09:08:58AM -0300, Ezequiel Garcia wrote:
> On Thu, Mar 14, 2013 at 03:06:56PM +0100, Jon Arne Jørgensen wrote:
> > This patch-set will add a driver for the Somagic SMI2021 chip.
> > 
> > This chip is found inside different usb video-capture devices.
> > Most of them are branded as EasyCap, but there also seems to be
> > some other brands selling devices with this chip.
> > 
> > This driver is split into two modules, where one is called smi2021-bootloader,
> > and the other is just called smi2021.
> > 
> > The bootloader is responsible for the upload of a firmware that is needed by some
> > versions of the devices.
> > 
> > All Somagic devices that need firmware seems to identify themselves
> > with the usb product id 0x0007. There is no way for the kernel to know
> > what firmware to upload to the device without user interaction.
> > 
> > If there is only one firmware present on the computer, the kernel
> > will upload that firmware to any device that identifies as 0x0007.
> > If there are multiple Somagic firmwares present, the user will have to pass
> > a module parameter to the smi2021-bootloader module to tell what firmware to use.
> > 
> 
> Nice job!
>
Thanks :)
 
> I have some minor comments on each patch, but also I don't agree
> with the patch splitting: what's the point in splitting and sending
> one patch per file?
> 
> It doesn't make it any easier to review, so why don't you just
> send one patch: "Introduce smi2021 driver"?
> 
> The rule is one patch per change, and I believe this whole patchset
> is just one change: adding a new driver.
> 

I think I read another patch to this mailinglist, where someone was told
to split his patch into one mail per file, but I can't find that thread
now :)

I will send the next version as a single mail, and see what happens...

> -- 
> Ezequiel García, Free Electrons
> Embedded Linux, Kernel and Android Engineering
> http://free-electrons.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/