linux-kernel - Re: [PATCH] tile: ns2cycles should use __raw_get_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 Mar 2013 10:13:41 -0400
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Henrik Austad <haustad@...co.com>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tile: ns2cycles should use __raw_get_cpu_var

On 3/23/2013 3:23 AM, Henrik Austad wrote:
> +	/* we don't have to disable preemptions here as each core has the same
> +	 * clock-frequency */

Looks OK except the comment is in the wrong style.  Kernel multiline comments

/*
 * Should look
 * like this.
 */

and use full sentences with punctuation.  (Also, don't hyphenate clock frequency here.)  Thanks!

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/