linux-kernel - Re: [PATCH] clocksource: exynos_mct: Add terminating entry for exynos_mct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Mar 2013 09:18:36 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Kukjin Kim <kgene.kim@...sung.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <john.stultz@...aro.org>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Changhwan Youn <chaos.youn@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource: exynos_mct: Add terminating entry for
 exynos_mct_ids table

2013/3/25 Kukjin Kim <kgene.kim@...sung.com>:
> Axel Lin wrote:
>>
>> The of_device_id table is supposed to be zero-terminated.
>>
>> Signed-off-by: Axel Lin <axel.lin@...ics.com>
>> ---
>>  drivers/clocksource/exynos_mct.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clocksource/exynos_mct.c
>> b/drivers/clocksource/exynos_mct.c
>> index 203ac05..3cdafc0 100644
>> --- a/drivers/clocksource/exynos_mct.c
>> +++ b/drivers/clocksource/exynos_mct.c
>> @@ -514,6 +514,7 @@ static void __init exynos4_timer_resources(struct
>> device_node *np)
>>  static const struct of_device_id exynos_mct_ids[] = {
>>       { .compatible = "samsung,exynos4210-mct", .data = (void
>> *)MCT_INT_SPI },
>>       { .compatible = "samsung,exynos4412-mct", .data = (void
>> *)MCT_INT_PPI },
>> +     { }
>
> Thanks for your pointing out. But as I know, it is not mandatory now.
>
> Please correct me if I'm wrong.

of_find_matching_node_and_match()
-> __of_match_node()
    while (matches->name[0] || matches->type[0] || matches->compatible[0])

My understanding is the implementation in _of_match_node() still needs
zero-terminated entry to break out the while loop.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/