lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 26 Mar 2013 14:23:49 +0100
From:	Richard Genoud <richard.genoud@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Tang Chen <tangchen@...fujitsu.com>, lenb@...nel.org,
	robert.moore@...el.com, lv.zheng@...el.com, ming.m.lin@...el.com,
	mpm@...enic.com, herbert@...dor.apana.org.au, rob@...dley.net,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org
Subject: Re: [RESEND PATCH 1/6] acpi: Remove the leading space of "unlock"
 label in acpi_memory_device_notify().

2013/3/26 Rafael J. Wysocki <rjw@...k.pl>:
> On Wednesday, March 06, 2013 04:30:06 PM Tang Chen wrote:
>> There is a leading space in front of "unlock" label in acpi_memory_device_notify(). Remove it.
>>
>> Signed-off-by: Tang Chen <tangchen@...fujitsu.com>
>> ---
>>  drivers/acpi/acpi_memhotplug.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>> index da1f82b..8a10c23 100644
>> --- a/drivers/acpi/acpi_memhotplug.c
>> +++ b/drivers/acpi/acpi_memhotplug.c
>> @@ -369,7 +369,7 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
>>                       kfree(ej_event);
>>               }
>>
>> - unlock:
>> +unlock:
>>               acpi_scan_lock_release();
>>               if (ACPI_SUCCESS(status))
>>                       return;
>
> The leading space is actually in agreement with the kernel coding style
> (and there's a reason why it's there).

Well, I'm curious. What's the reason ?
I didn't see anything in Documentation/CodingStyle about that.

Regards,
Richard.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ