lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 Mar 2013 09:27:49 +0530 From: Viresh Kumar <viresh.kumar@...aro.org> To: Axel Lin <axel.lin@...ics.com> Cc: Thierry Reding <thierry.reding@...onic-design.de>, Shiraz Hashim <shiraz.hashim@...com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] pwm: spear: Fix enable pwm output On 30 March 2013 09:16, Axel Lin <axel.lin@...ics.com> wrote: > The logic to check return value of clk_enable() is reversed, thus > when clek_enable() success PWMCR_PWM_ENABLE bit is never set. Fix it. s/clek/clk And write it as: The logic to check return value of clk_enable() is reversed, thus when clk_enable() passes PWMCR_PWM_ENABLE bit is not set. Fix it. > > Signed-off-by: Axel Lin <axel.lin@...ics.com> > --- > drivers/pwm/pwm-spear.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c > index 69a2d9e..cccb430 100644 > --- a/drivers/pwm/pwm-spear.c > +++ b/drivers/pwm/pwm-spear.c > @@ -143,7 +143,7 @@ static int spear_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) > u32 val; > > rc = clk_enable(pc->clk); > - if (!rc) > + if (rc) > return rc; This is okay but there is one more mistake like this in this driver. Fix that too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists