linux-kernel - Re: [PATCH v2] pwm: spear: Fix enable pwm output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 Mar 2013 15:25:41 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Thierry Reding <thierry.reding@...onic-design.de>,
	Shiraz Hashim <shiraz.hashim@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pwm: spear: Fix enable pwm output

On 30 March 2013 11:07, Axel Lin <axel.lin@...ics.com> wrote:
> The logic to check return value of clk_enable() is reversed, thus
> when clk_enable() passes PWMCR_PWM_ENABLE bit is not set. Fix it.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/pwm/pwm-spear.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I am so sorry. clk_prepare also has the same issue :(
Please fix that too and i will ack it ASAP.

@Shiraz: Any idea how they went through?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/