linux-kernel - [PATCH] acpi/video: lcd_get_level_current doen't return current level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 Mar 2013 17:01:41 +0400
From:	Artem Savkov <artem.savkov@...il.com>
To:	dannybaumann@....de
Cc:	aaron.lu@...el.com, rafael.j.wysocki@...el.com,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Artem Savkov <artem.savkov@...il.com>
Subject: [PATCH] acpi/video: lcd_get_level_current doen't return current level

acpi_video_device_lcd_get_level_current() called acpi_video_bqc_value_to_level()
with "*level" as a second argument, resulting in level being returned based on
initial input, not current brightness, breaking backlight controls.

Signed-off-by: Artem Savkov <artem.savkov@...il.com>
---
 drivers/acpi/video.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 3cdd047..68a777b 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -505,7 +505,8 @@ acpi_video_device_lcd_get_level_current(struct acpi_video_device *device,
 				return 0;
 			}
 
-			*level = acpi_video_bqc_value_to_level(device, *level);
+			*level = acpi_video_bqc_value_to_level(device,
+					device->brightness->curr);
 
 			for (i = 2; i < device->brightness->count; i++)
 				if (device->brightness->levels[i] == *level) {
-- 
1.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/