linux-kernel - Re: [PATCH] cpufreq: Raname index as data in cpufreq_frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 31 Mar 2013 09:16:42 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	cpufreq@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org,
	patches@...aro.org, robin.randhawa@....com,
	Steve.Bannister@....com, Liviu.Dudau@....com,
	charles.garcia-tobin@....com, arvind.chauhan@....com,
	Sekhar Nori <nsekhar@...com>, Ben Dooks <ben-linux@...ff.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Arnd Bergmann <arnd@...db.de>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Olof Johansson <olof@...om.net>,
	Stephen Warren <swarren@...dotorg.org>,
	Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] cpufreq: Raname index as data in cpufreq_frequency_table

On 31 March 2013 07:16, Rafael J. Wysocki <rjw@...k.pl> wrote:
> On Sunday, March 31, 2013 07:03:04 AM Viresh Kumar wrote:
>> On 31 March 2013 03:31, Rafael J. Wysocki <rjw@...k.pl> wrote:
>> > Sorry, I won't apply this.  It changes too much stuff at a time and I'm not
>> > really sure if the change being made is necessary.
>>
>> Hmm.. I thought it is important  as it puts the real meaning of "index" in the
>> code.
>
> And what does that change, really?  What about documenting the meaning of
> "index" instead?

Probably not the logic but perception. People don't necessarily go through
Documentation but code for writing new stuff. And so code should reflect the
real meaning.

In case we write something like following in documentation:
"Index: This is driver specific data for each frequency. Core doesn't use it."

Then "Index" looks even more wrong. Its not the right name for any such
variable. And so it should be fixed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/