linux-kernel - Re: [PATCH] pwm: twl: Return proper error if twl6030_pwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Apr 2013 09:14:54 +0200
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Thierry Reding <thierry.reding@...onic-design.de>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable()
 fails

On 03/31/2013 05:07 PM, Axel Lin wrote:
> Return proper error instead of 0 if twl6030_pwm_enable() fails.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Acked-by: Peter Ujfalusi <peter.ujfalusi@...com>

> ---
>  drivers/pwm/pwm-twl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
> index ee7fa5d..2782001 100644
> --- a/drivers/pwm/pwm-twl.c
> +++ b/drivers/pwm/pwm-twl.c
> @@ -248,7 +248,7 @@ static int twl6030_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
>  	twl->twl6030_toggle3 = val;
>  out:
>  	mutex_unlock(&twl->mutex);
> -	return 0;
> +	return ret;
>  }
>  
>  static void twl6030_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/