linux-kernel - Re: [PATCH] Staging: Android: looping issue, need break when get value firstly.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Apr 2013 16:48:05 -0700
From:	Arve Hjønnevåg <arve@...roid.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Chen Gang <gang.chen@...anux.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Mirsal Ennaime <mirsal@...sal.fr>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: Android: looping issue, need break when get
 value firstly.

On Fri, Apr 5, 2013 at 3:01 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Fri, Apr 05, 2013 at 04:05:25PM +0800, Chen Gang wrote:
>>
>>   need break when 'target_thread' get value, firstly.
>>
>>     'tmp' is a stack (thread->transaction_stack),
>>     if 'proc' was the same between child node and parent node,
>>     the child would have higher priority than parent.
>
> Are you sure about this?
>
> have you tested it?
>

Theoretically this should not change the behavior. The purpose of this
code it to make sure only thread per process is part of a transaction
stack, so if it finds more than one transaction with a matching
process, they should all point to the same thread object. I think a
better change description is needed though.

--
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/