linux-kernel - Re: [PATCH] Staging: Android: looping issue, need break when get value firstly.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 06 Apr 2013 17:47:24 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Arve Hjønnevåg <arve@...roid.com>
CC:	Greg KH <gregkh@...uxfoundation.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Mirsal Ennaime <mirsal@...sal.fr>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: Android: looping issue, need break when get
 value firstly.

On 2013年04月06日 07:48, � wrote:
> Theoretically this should not change the behavior. The purpose of this
> code it to make sure only thread per process is part of a transaction
> stack, so if it finds more than one transaction with a matching
> process, they should all point to the same thread object. I think a
> better change description is needed though.

  after reading code again, I think:
    in our condition, one proc can be related with multiple threads.

  can you provide more information for:
    why can we be sure "they should all point to the same thread object" ?

  result:
    if it is an issue (can not be sure all point to the same thread object)
      it seems need additional considerations for it.
      what my fix seems incorrect, either.
        (for its transaction processing, it seems not should obey stack rules).

    else (can be sure)
      my patch seems minor (only can increasing a little performance).
      it is not quite suitable to spend much time to test a minor patch !!

    so whether what will happen, my patch seems obsoleted !!

  :-(


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/