linux-kernel - Re: [PATCH] ARM: dts: Disable the RTC by default on exynos5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 09 Apr 2013 03:25:23 +0900
From:	Kukjin Kim <kgene.kim@...il.com>
To:	Doug Anderson <dianders@...omium.org>
CC:	Kukjin Kim <kgene.kim@...sung.com>,
	linux-samsung-soc@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	Padmavathi Venna <padma.v@...sung.com>,
	Giridhar Maruthy <giridhar.m@...sung.com>,
	Jingoo Han <jg1.han@...sung.com>, linux-kernel@...r.kernel.org,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Olof Johansson <olof@...om.net>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: Disable the RTC by default on exynos5

On 04/09/13 01:58, Doug Anderson wrote:
> This change makes the rtc on the exynos5250 and 5440 disabled by
> default to match exynos4.
>
> Ever since the common clock framework came in came in, exynos5250
> boards have dumped lots of warnings in the boot log.  It turns out
> that we don't see those on exynos4 since the rtc is disabled by
> default.  While we need to get to the bottom of the problems with the
> RTC, it still makes sense to have the default state of the RTC on
> exynos boards match.
>
> For the record, warnings look like this:
>    ------------[ cut here ]------------
>    WARNING: at /.../drivers/clk/clk.c:771 __clk_enable+0x34/0xb0()
>    Modules linked in:
>    [<80015bfc>] (unwind_backtrace+0x0/0xec) from [<804717f0>] (dump_stack+0x20/0x24)
>    [<804717f0>] (dump_stack+0x20/0x24) from [<80023cd0>] (warn_slowpath_common+0x5c/0x7c)
>    [<80023cd0>] (warn_slowpath_common+0x5c/0x7c) from [<80023d1c>] (warn_slowpath_null+0x2c/0x34)
>    [<80023d1c>] (warn_slowpath_null+0x2c/0x34) from [<8035ddb0>] (__clk_enable+0x34/0xb0)
>    [<8035ddb0>] (__clk_enable+0x34/0xb0) from [<8035de54>] (clk_enable+0x28/0x3c)
>    [<8035de54>] (clk_enable+0x28/0x3c) from [<8031a160>] (s3c_rtc_probe+0xf4/0x434)
>    [<8031a160>] (s3c_rtc_probe+0xf4/0x434) from [<8028e288>] (platform_drv_probe+0x24/0x28)
>    [<8028e288>] (platform_drv_probe+0x24/0x28) from [<8028ce10>] (driver_probe_device+0xbc/0x22c)
>    [<8028ce10>] (driver_probe_device+0xbc/0x22c) from [<8028cff8>] (__driver_attach+0x78/0x9c)
>    [<8028cff8>] (__driver_attach+0x78/0x9c) from [<8028bdfc>] (bus_for_each_dev+0x64/0xac)
>    [<8028bdfc>] (bus_for_each_dev+0x64/0xac) from [<8028c7e0>] (driver_attach+0x28/0x30)
>    [<8028c7e0>] (driver_attach+0x28/0x30) from [<8028c43c>] (bus_add_driver+0xe0/0x234)
>    [<8028c43c>] (bus_add_driver+0xe0/0x234) from [<8028d55c>] (driver_register+0xac/0x13c)
>    [<8028d55c>] (driver_register+0xac/0x13c) from [<8028e4f4>] (platform_driver_register+0x54/0x68)
>    [<8028e4f4>] (platform_driver_register+0x54/0x68) from [<8065c944>] (s3c_rtc_driver_init+0x14/0x1c)
>    [<8065c944>] (s3c_rtc_driver_init+0x14/0x1c) from [<800086d8>] (do_one_initcall+0x60/0x138)
>    [<800086d8>] (do_one_initcall+0x60/0x138) from [<80633a8c>] (kernel_init_freeable+0x108/0x1d0)
>    [<80633a8c>] (kernel_init_freeable+0x108/0x1d0) from [<8046d2f8>] (kernel_init+0x1c/0xf4)
>    [<8046d2f8>] (kernel_init+0x1c/0xf4) from [<8000e358>] (ret_from_fork+0x14/0x20)
>    ---[ end trace 4bcdc801c868d73f ]---
>
> Signed-off-by: Doug Anderson<dianders@...omium.org>
> ---
>   arch/arm/boot/dts/exynos5250.dtsi | 1 +
>   arch/arm/boot/dts/exynos5440.dtsi | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index dc55e33..892b724 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -183,6 +183,7 @@
>   		interrupts =<0 43 0>,<0 44 0>;
>   		clocks =<&clock 337>;
>   		clock-names = "rtc";
> +		status = "disabled";
>   	};
>
>   	tmu@...60000 {
> diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
> index 25c6134..a8ceef4 100644
> --- a/arch/arm/boot/dts/exynos5440.dtsi
> +++ b/arch/arm/boot/dts/exynos5440.dtsi
> @@ -181,5 +181,6 @@
>   		interrupts =<0 17 0>,<0 16 0>;
>   		clocks =<&clock 21>;
>   		clock-names = "rtc";
> +		status = "disabled";
>   	};
>   };

Ooops, OK.

Applied, thanks.

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/