linux-kernel - Re: [PATCH] drivers/block/drbd: remove erroneous semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Apr 2013 22:45:10 +0200
From:	Lars Ellenberg <lars.ellenberg@...bit.com>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	drbd-dev@...ts.linbit.com, drbd-user@...ts.linbit.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/block/drbd: remove erroneous semicolon

On Wed, Apr 03, 2013 at 04:00:31PM +0800, Chen Gang wrote:
> Hello maintainers:
> 
>   when you have time, please help to check this patch whether is OK.
> 
>   thanks.

Thanks.

It has already been queued in:
http://git.kernel.dk/?p=linux-block.git;a=commit;h=0b6ef4164f50698eee536903d69d086add1a7889

> On 2013年03月27日 14:56, Chen Gang wrote:
> > 
> >   need remove it, or always return -EBUSY.
> >   it is found by compiler with 'EXTRA_CFLAG=-W'.
> > 
> > Signed-off-by: Chen Gang <gang.chen@...anux.com>
> > ---
> >  drivers/block/drbd/drbd_actlog.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c
> > index 6afe173..6608076 100644
> > --- a/drivers/block/drbd/drbd_actlog.c
> > +++ b/drivers/block/drbd/drbd_actlog.c
> > @@ -389,7 +389,7 @@ int drbd_al_begin_io_nonblock(struct drbd_conf *mdev, struct drbd_interval *i)
> >  		if (unlikely(tmp != NULL)) {
> >  			struct bm_extent  *bm_ext = lc_entry(tmp, struct bm_extent, lce);
> >  			if (test_bit(BME_NO_WRITES, &bm_ext->flags)) {
> > -				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags));
> > +				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags))
> >  					return -EBUSY;
> >  				return -EWOULDBLOCK;
> >  			}
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/