linux-kernel - Re: [PATCH -next 1/3] bcache: Add missing #include <linux/prefetch.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Apr 2013 14:00:20 -0700
From:	Kent Overstreet <koverstreet@...gle.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Randy Dunlap <rdunlap@...radead.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org
Subject: Re: [PATCH -next 1/3] bcache: Add missing #include <linux/prefetch.h>

On Sun, Apr 07, 2013 at 02:15:49PM -0700, David Rientjes wrote:
> On Wed, 27 Mar 2013, Kent Overstreet wrote:
> 
> > Nope - looks like __WARN() doesn't exist if CONFIG_BUG=n, whoops.
> > 
> > Adding this to the queue:
> > 
> > commit 796c213186b850b3e6e8d5fd5799b0fd74721ea3
> > Author: Kent Overstreet <koverstreet@...gle.com>
> > Date:   Wed Mar 27 12:47:45 2013 -0700
> > 
> >     bcache: Use WARN_ONCE() instead of __WARN()
> >     
> >     Signed-off-by: Kent Overstreet <koverstreet@...gle.com>
> > 
> > diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c
> > index d4f2164..cb4578a 100644
> > --- a/drivers/md/bcache/bset.c
> > +++ b/drivers/md/bcache/bset.c
> > @@ -883,7 +883,7 @@ struct bkey *bch_btree_iter_next(struct btree_iter *iter)
> >  		iter->data->k = bkey_next(iter->data->k);
> >  
> >  		if (iter->data->k > iter->data->end) {
> > -			__WARN();
> > +			WARN_ONCE(1, "bset was corrupt!\n");
> >  			iter->data->k = iter->data->end;
> >  		}
> >  
> 
> This problem still persists in linux-next as of today, how is this fix 
> being pushed?

Sorry for the delay, I've been moving all last week - I just sent Jens a
pull request with the latest bcache fixes, though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/