linux-kernel - Re: [PATCH] x86, mce: Print warning if MCE handler fails to register /dev/mcelog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 09 Apr 2013 13:20:53 -0600
From:	Khalid Aziz <khalid.aziz@...cle.com>
To:	"Luck, Tony" <tony.luck@...el.com>
CC:	"bp@...en8.de" <bp@...en8.de>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86, mce: Print warning if MCE handler fails to register
 /dev/mcelog

On 04/09/2013 12:30 PM, Luck, Tony wrote:
> -	misc_register(&mce_chrdev_device);
> +	if (misc_register(&mce_chrdev_device) != 0)
> +		pr_warn("Failed to register mcelog device\n");
>
> Did this actually happen to you?  Or is this just "good practice" to check the
> return value from misc_register?
>

No, I did not see this happen. It is just "good practice". If it were to 
happen, mcelog daemon would fail to get any mce records and it will not 
be easy to figure out what happened. Most other places in kernel where 
misc_register() is called, do check for return code and take action if 
it fails.

--
Khalid

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/