linux-kernel - Re: [PATCH v3 02/22] x86, microcode: Use common get_ramdisk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Apr 2013 13:34:33 +0800
From:	Tang Chen <tangchen@...fujitsu.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>, Thomas Renninger <trenn@...e.de>,
	linux-kernel@...r.kernel.org, Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH v3 02/22] x86, microcode: Use common get_ramdisk_image()

On 04/05/2013 07:46 AM, Yinghai Lu wrote:
> Use common get_ramdisk_image() to get ramdisk start phys address.
>
> We need this to get correct ramdisk adress for 64bit bzImage that
> initrd can be loaded above 4G by kexec-tools.
>
> Signed-off-by: Yinghai Lu<yinghai@...nel.org>
> Cc: Fenghua Yu<fenghua.yu@...el.com>
> Acked-by: Tejun Heo<tj@...nel.org>
> ---
>   arch/x86/kernel/microcode_intel_early.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/microcode_intel_early.c b/arch/x86/kernel/microcode_intel_early.c
> index d893e8e..ea57bd8 100644
> --- a/arch/x86/kernel/microcode_intel_early.c
> +++ b/arch/x86/kernel/microcode_intel_early.c
> @@ -742,8 +742,8 @@ load_ucode_intel_bsp(void)
>   	struct boot_params *boot_params_p;
>
>   	boot_params_p = (struct boot_params *)__pa_nodebug(&boot_params);
> -	ramdisk_image = boot_params_p->hdr.ramdisk_image;
> -	ramdisk_size  = boot_params_p->hdr.ramdisk_size;
> +	ramdisk_image = get_ramdisk_image(boot_params_p);
> +	ramdisk_size  = get_ramdisk_image(boot_params_p);

Shoule be get_ramdisk_size(boot_params_p) ?

>   	initrd_start_early = ramdisk_image;
>   	initrd_end_early = initrd_start_early + ramdisk_size;
>
> @@ -752,8 +752,8 @@ load_ucode_intel_bsp(void)
>   		(unsigned long *)__pa_nodebug(&mc_saved_in_initrd),
>   		initrd_start_early, initrd_end_early,&uci);
>   #else
> -	ramdisk_image = boot_params.hdr.ramdisk_image;
> -	ramdisk_size  = boot_params.hdr.ramdisk_size;
> +	ramdisk_image = get_ramdisk_image(&boot_params);
> +	ramdisk_size  = get_ramdisk_size(&boot_params);
>   	initrd_start_early = ramdisk_image + PAGE_OFFSET;
>   	initrd_end_early = initrd_start_early + ramdisk_size;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/