linux-kernel - Re: [PATCH] kernel: audit_watch: resource management: better reset to NULL.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Apr 2013 16:18:50 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Eric Paris <eparis@...hat.com>, Al Viro <viro@...iv.linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel: audit_watch: resource management: better reset
 to NULL.


  oh, sorry, this patch is incorrect, please skip it.


On 2013年04月12日 12:50, Chen Gang wrote:
> 
>   better to set krule->watch = NULL.
>   maybe it is not a real issue, but can make code clearer,
>   so can help the readers to analyse another issues.
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  kernel/audit_watch.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c
> index 22831c4..abd8fdb 100644
> --- a/kernel/audit_watch.c
> +++ b/kernel/audit_watch.c
> @@ -456,6 +456,7 @@ void audit_remove_watch_rule(struct audit_krule *krule)
>  
>  	if (list_empty(&watch->rules)) {
>  		audit_remove_watch(watch);
> +		krule->watch = NULL;
>  
>  		if (list_empty(&parent->watches)) {
>  			audit_get_parent(parent);
> 


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/