linux-kernel - Re: [PATCH 3/7] dump_stack: consolidate dump_stack() implementations and unify their behaviors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Apr 2013 16:39:01 -0400
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Tejun Heo <tj@...nel.org>
CC:	<linux-arch@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<akpm@...ux-foundation.org>, <mingo@...hat.com>, <x86@...nel.org>,
	<rth@...ddle.net>, <linux@....linux.org.uk>, <msalter@...hat.com>,
	<starvik@...s.com>, <dhowells@...hat.com>, <tony.luck@...el.com>,
	<benh@...nel.crashing.org>, <takata@...ux-m32r.org>,
	<geert@...ux-m68k.org>, <james.hogan@...tec.com>,
	<monstr@...str.eu>, <ralf@...ux-mips.org>, <jonas@...thpole.se>,
	<rkuo@...eaurora.org>, <schwidefsky@...ibm.com>,
	<liqin.chen@...plusct.com>, <davem@...emloft.net>,
	<lethal@...ux-sh.org>, <vgupta@...opsys.com>, <chris@...kel.net>,
	<ysato@...rs.sourceforge.jp>, <gxt@...c.pku.edu.cn>,
	<jdike@...toit.com>, Heiko Carstens <heiko.carstens@...ibm.com>,
	<linux-s390@...r.kernel.org>, Mike Frysinger <vapier@...too.org>,
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH 3/7] dump_stack: consolidate dump_stack() implementations
 and unify their behaviors

On 4/3/2013 3:14 PM, Tejun Heo wrote:
> This patch expands the dummy fallback dump_stack() implementation in
> lib/dump_stack.c such that it prints out debug information (taken from
> x86) and invokes show_stack(NULL, NULL) and drops arch-specific
> dump_stack() implementations in all archs except blackfin.  Blackfin's
> dump_stack() does something wonky that I don't understand.

arch/tile has a dump_stack() entry point in assembly (see arch/tile/kernel/entry.S) that passes to _dump_stack(), which passes to dump_stack_regs(), which passes to tile_show_stack().  Similarly, show_stack() passes to tile_show_stack(), which does lots of work to cross into userspace and continue showing the stack if possible, print symbol info for both kernel and userspace, etc.  I don't know if that's all supported fully in Tejun's generic version.

Would it make sense for me to look at this after it's merged up into -next and see what tile needs?  Unfortunately I'm taking off for a week's vacation so won't be able to do much until after the 23rd.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/