linux-kernel - Re: arch/s390/lib/uaccess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Apr 2013 07:58:23 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux-s390@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

On Sun, Apr 14, 2013 at 10:53:27PM -0700, Joe Perches wrote:
> On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote:
> > On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote:
> > > Commit ea81531d ("s390/uaccess: fix page table walk")
> > > added this code.  It looks like it should have break;
> > > for each case.
> > no, the fallthrough is on purpose for each case statement.
> 
> Hi again.  It might be useful to add /* fallthrough */
> or some other comment showing it's intentional.

I might add some comment above the function, since for everybody
*knowing* the architecture it's obvious ;) that these must be
fallthroughs.
How did you stuble across this?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/