linux-kernel - Re: drivers/base/core.c: about device_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Apr 2013 10:55:11 +0200
From:	Federico Vaga <federico.vaga@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alessandro Rubini <rubini@...dd.com>
Cc:	linux-kernel@...r.kernel.org,
	Cornelia Huck <cornelia.huck@...ibm.com>
Subject: Re: drivers/base/core.c: about device_find_child() function

Thank you very much Greg
 
> > I did not study serial_core, I was looking only for device_find_child().
> > Probably I'm missing something. Anyway, here what does not convice me:
> > 
> > (line number on next-20130412)
> > serial_core.c:2003
> > 
> > 	tty_dev = device_find_child(uport->dev, &match, serial_match_port);
> > 	if (!uport->suspended && device_may_wakeup(tty_dev)) {
> > 	
> > 		if (uport->irq_wake) {
> > 		
> > 			disable_irq_wake(uport->irq);
> > 			uport->irq_wake = 0;
> > 		
> > 		}
> > 
> > +               put_device(tty_dev);
> > 
> > 		mutex_unlock(&port->mutex);
> > 		return 0;
> > 	
> > 	}
> > 
> > +	put_device(tty_dev);
> > 
> > 	uport->suspended = 0;
> > 
> > serial_core:1936
> > 
> > 	tty_dev = device_find_child(uport->dev, &match, serial_match_port);
> > 	if (device_may_wakeup(tty_dev)) {
> > 	
> > 		if (!enable_irq_wake(uport->irq))
> > 		
> > 			uport->irq_wake = 1;
> > 		
> > 		put_device(tty_dev);
> > 		mutex_unlock(&port->mutex);
> > 		return 0;
> > 	
> > 	}
> > 
> > +	put_device(tty_dev);
> 
> That looks like a good patch, care to properly send it, (after you test
> it first of course), so that we can apply it?

Yes, I can do it and test it. I hope to find the time for a test in these 
days.

-- 
Federico Vaga
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/