linux-kernel - Re: [PATCH] RTC: rtc-twl: Convert to module_platform_driver() and relocate reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Apr 2013 10:16:00 +0200
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Tomi Valkeinen <tomi.valkeinen@....fi>
CC:	Alessandro Zummo <a.zummo@...ertech.it>,
	Tony Lindgren <tony@...mide.com>, <rtc-linux@...glegroups.com>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	Christoph Fritz <chf.fritz@...glemail.com>,
	Grygorii Strashko <grygorii.strashko@...com>
Subject: Re: [PATCH] RTC: rtc-twl: Convert to module_platform_driver() and
 relocate reg_map init

Hi Tomi,

On 04/16/2013 10:10 AM, Tomi Valkeinen wrote:
> Hi,
> 
> On 2013-04-16 10:44, Peter Ujfalusi wrote:
>> Convert the driver to use module_platform_driver() to register the platform
>> driver and relocate the rtc_reg_map initialization to platform driver's
>> probe function.
>> In this way we can make sure that the twl-core has been already probed since
>> the core driver will create the device at the end of it's probe function.
>>
>> Reported-by: Christoph Fritz <chf.fritz@...glemail.com>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> 
> I think there are two distinct things here. The actual fix for the
> regmap, and a module_platform_driver cleanup. I would suggest having
> them in separate patches.
> 
> And even if these are combined, I think the patch subject and
> description should talk about fixing the regmap bug. Now it's rather
> unclear that an actual bug is being fixed.

Good point. My thinking was that when I convert the driver to
module_platform_driver() the reg map init must be moved to platform_driver's
probe anyways.
I'll separate the patch and write a bit better commit message for the first.

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/