linux-kernel - Re: [PATCH RESEND 05/11] thermal: rename get_tz_trend to thermal_zone_trend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Apr 2013 15:20:51 -0400
From:	Eduardo Valentin <eduardo.valentin@...com>
To:	Zhang Rui <rui.zhang@...el.com>
CC:	Eduardo Valentin <eduardo.valentin@...com>,
	<linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND 05/11] thermal: rename get_tz_trend to thermal_zone_trend_get

On 17-04-2013 11:10, Zhang Rui wrote:
> On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote:
>> To follow the prefix names used by the thermal exported functions,
>> this patch renames get_tz_trend to thermal_zone_trend_get.
>>
>> Signed-off-by: Eduardo Valentin <eduardo.valentin@...com>
>
> NACK.
>
> get_tz_trend will not be exported as API any more.

Same comment as in patch 04. How about keeping this patch, but updating 
the commit description? I dont see why not keep one single nameing 
pattern in the file. it makes reading the code more pleasant.

>
> thanks,
> rui
>> ---
>>   Documentation/thermal/sysfs-api.txt |    2 +-
>>   drivers/thermal/step_wise.c         |    2 +-
>>   drivers/thermal/thermal_sys.c       |    4 ++--
>>   include/linux/thermal.h             |    2 +-
>>   4 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt
>> index 059b3bf..a9abb84 100644
>> --- a/Documentation/thermal/sysfs-api.txt
>> +++ b/Documentation/thermal/sysfs-api.txt
>> @@ -351,7 +351,7 @@ crosses any of the configured thresholds.
>>
>>   5. Export Symbol APIs:
>>
>> -5.1: get_tz_trend:
>> +5.1: thermal_zone_trend_get:
>>   This function returns the trend of a thermal zone, i.e the rate of change
>>   of temperature of the thermal zone. Ideally, the thermal sensor drivers
>>   are supposed to implement the callback. If they don't, the thermal
>> diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c
>> index 407cde3..a640e2b 100644
>> --- a/drivers/thermal/step_wise.c
>> +++ b/drivers/thermal/step_wise.c
>> @@ -116,7 +116,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
>>   		tz->ops->get_trip_type(tz, trip, &trip_type);
>>   	}
>>
>> -	trend = get_tz_trend(tz, trip);
>> +	trend = thermal_zone_trend_get(tz, trip);
>>
>>   	if (tz->temperature >= trip_temp)
>>   		throttle = true;
>> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
>> index 44e89c0..242c82a 100644
>> --- a/drivers/thermal/thermal_sys.c
>> +++ b/drivers/thermal/thermal_sys.c
>> @@ -153,7 +153,7 @@ static void release_idr(struct idr *idr, struct mutex *lock, int id)
>>   		mutex_unlock(lock);
>>   }
>>
>> -int get_tz_trend(struct thermal_zone_device *tz, int trip)
>> +int thermal_zone_trend_get(struct thermal_zone_device *tz, int trip)
>>   {
>>   	enum thermal_trend trend;
>>
>> @@ -168,7 +168,7 @@ int get_tz_trend(struct thermal_zone_device *tz, int trip)
>>
>>   	return trend;
>>   }
>> -EXPORT_SYMBOL(get_tz_trend);
>> +EXPORT_SYMBOL(thermal_zone_trend_get);
>>
>>   struct thermal_instance *thermal_instance_get(struct thermal_zone_device *tz,
>>   			struct thermal_cooling_device *cdev, int trip)
>> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
>> index e2a49e1..542a39c 100644
>> --- a/include/linux/thermal.h
>> +++ b/include/linux/thermal.h
>> @@ -238,7 +238,7 @@ struct thermal_cooling_device *thermal_cooling_device_register(char *, void *,
>>   		const struct thermal_cooling_device_ops *);
>>   void thermal_cooling_device_unregister(struct thermal_cooling_device *);
>>
>> -int get_tz_trend(struct thermal_zone_device *, int);
>> +int thermal_zone_trend_get(struct thermal_zone_device *, int);
>>   struct thermal_instance *thermal_instance_get(struct thermal_zone_device *,
>>   		struct thermal_cooling_device *, int);
>>   void thermal_cdev_update(struct thermal_cooling_device *);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/