linux-kernel - Re: linux-next: Tree for Apr 18 [ call-trace: drm | x86 | smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 20 Apr 2013 23:03:17 +0200
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Davidlohr Bueso <davidlohr.bueso@...com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Rik van Riel <riel@...riel.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next <linux-next@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"the arch/x86 maintainers" <x86@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Paul McKenney <paul.mckenney@...aro.org>,
	DRI <dri-devel@...ts.freedesktop.org>,
	Dave Airlie <airlied@...hat.com>,
	Emmanuel Benisty <benisty.e@...il.com>
Subject: Re: linux-next: Tree for Apr 18 [ call-trace: drm | x86 | smp | rcu
 related? ]

On Sat, Apr 20, 2013 at 10:00 PM, Davidlohr Bueso
<davidlohr.bueso@...com> wrote:
> On Sat, 2013-04-20 at 02:19 +0200, Sedat Dilek wrote:
>> On Sat, Apr 20, 2013 at 2:06 AM, Sedat Dilek <sedat.dilek@...il.com> wrote:
>> > On Sat, Apr 20, 2013 at 1:02 AM, Linus Torvalds
>> > <torvalds@...ux-foundation.org> wrote:
>> >> On Fri, Apr 19, 2013 at 3:55 PM, Sedat Dilek <sedat.dilek@...il.com> wrote:
>> >>>
>> >>> Davidlohr pointed to this patch (tested the triplet):
>> >>>
>> >>> ipc, sem: do not call sem_lock when bogus sma:
>> >>> https://lkml.org/lkml/2013/3/31/12
>> >>>
>> >>> Is that what you mean?
>> >>
>> >> Yup.
>> >>
>> >
>> > Davidlohr Bueso (1):
>> >       ipc, sem: do not call sem_lock when bogus sma
>> >
>> > Linus Torvalds (1):
>> >       crazy rcu double free debug hack
>> >
>> > With ***both*** patches applied I am able to build a Linux-kernel with
>> > 4 parallel-make-jobs again.
>> > David's or your patch alone are not sufficient!
>> >
>>
>> [ Still both patches applied ]
>>
>> To correct myself... The 1st run was OK.
>>
>> The 2nd run shows a NULL-pointer-deref (excerpt):
>>
>> [  178.490583] BUG: spinlock bad magic on CPU#1, sh/8066
>> [  178.490595]  lock: 0xffff88008b53ea18, .magic: 6b6b6b6b, .owner:
>> make/8068, .owner_cpu: 3
>> [  178.490599] BUG: unable to handle kernel NULL pointer dereference
>> at           (null)
>> [  178.490608] IP: [<ffffffff812bacd0>] update_queue+0x70/0x210
>> [  178.490610] PGD 0
>> [  178.490612] Oops: 0000 [#1] SMP
>> ...
>
> The exit_sem() >> do_smart_update() >> update_queue() calls seem pretty
> well protected. Furthermore we're asserting that sma->sem_perm.lock is
> taken. This could just be a consequence of another issue. Earlier this
> week Andrew pointed out a potential race in semctl_main() where
> sma->sem_perm.deleted could be changed when cmd == GETALL.
>
> Sedat, could you try the attached patch to keep the ipc lock acquired
> (on top of the three patches you're already using) and let us know how
> it goes? We could also just have the RCU read lock instead of
> ->sem.perm.lock for GETALL, but lets play it safe for now.
>

I had to refresh your patch and it contain strange ^M charachters as well.

NOPE, the machine gets FROZEN (cold reboot).

- Sedat -

P.S.: I have attached all 4 patches against next-20130419 in case
someone wants to follow.

> Thanks,
> Davidlohr
>

Download attachment "0001-ipc-sem-untangle-RCU-locking-with-find_alloc_undo.patch" of type "application/octet-stream" (3214 bytes)

Download attachment "0002-ipc-sem-fix-lockdep-false-positive.patch" of type "application/octet-stream" (4734 bytes)

Download attachment "0003-ipc-sem-do-not-call-sem_lock-when-bogus-sma.patch" of type "application/octet-stream" (1442 bytes)

Download attachment "0004-ipc-sem-check-if-the-ipc-lock-has-been-already-taken.patch" of type "application/octet-stream" (1101 bytes)