linux-kernel - [PATCH] xen: clear IRQ_NOAUTOEN and IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Apr 2013 20:39:37 +0100
From:	Julien Grall <julien.grall@...aro.org>
To:	xen-devel@...ts.xensource.com, linux-kernel@...r.kernel.org
Cc:	konrad.wilk@...cle.com, Stefano.Stabellini@...citrix.com,
	patches@...aro.org, Julien Grall <julien.grall@...aro.org>
Subject: [PATCH] xen: clear IRQ_NOAUTOEN and IRQ_NOREQUEST when a VIRQ is bound

Reset the IRQ_NOAUTOEN and IRQ_NOREQUEST flags that are enabled by
default on ARM. If IRQ_NOAUTOEN is set, __setup_irq doesn't call
irq_startup, that is responsible for calling irq_unmask at startup time.
As a result event channels remain masked.

The clear is already made in bind_evtchn_to_irq with commit a8636c0 but was
missing in bind_virq_to_irq.

Signed-off-by: Julien Grall <julien.grall@...aro.org>
---
 drivers/xen/events.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index d8cc812..b0ad226 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -994,6 +994,7 @@ int bind_virq_to_irq(unsigned int virq, unsigned int cpu)
 		WARN_ON(info == NULL || info->type != IRQT_VIRQ);
 	}
 
+	irq_clear_status_flags(irq, IRQ_NOREQUEST|IRQ_NOAUTOEN);
 out:
 	mutex_unlock(&irq_mapping_update_lock);
 
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/