lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Apr 2013 23:17:16 -0400 From: kosaki.motohiro@...il.com To: linux-kernel@...r.kernel.org Cc: Olivier Langlois <olivier@...llion01.com>, Martin Schwidefsky <schwidefsky@...ibm.com>, Steven Rostedt <rostedt@...dmis.org>, David Miller <davem@...emloft.net>, Thomas Gleixner <tglx@...utronix.de>, Frederic Weisbecker <fweisbec@...il.com>, Ingo Molnar <mingo@...nel.org>, Peter Zijlstra <peterz@...radead.org>, KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> Subject: [PATCH 08/10] posix-cpu-timers: check_thread_timers() uses task_sched_runtime() From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> A type of tsk->se.sum_exec_runtime is u64. Thus reading it is racy when running 32bit. We should use task_sched_runtime(). Cc: Olivier Langlois <olivier@...llion01.com> CC: Martin Schwidefsky <schwidefsky@...ibm.com> Cc: Steven Rostedt <rostedt@...dmis.org> Cc: Thomas Gleixner <tglx@...utronix.de> Cc: Frederic Weisbecker <fweisbec@...il.com> Cc: Ingo Molnar <mingo@...nel.org> Cc: Peter Zijlstra <peterz@...radead.org> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> --- kernel/posix-cpu-timers.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c index c69b8d8..4043282 100644 --- a/kernel/posix-cpu-timers.c +++ b/kernel/posix-cpu-timers.c @@ -958,7 +958,8 @@ static void check_thread_timers(struct task_struct *tsk, struct cpu_timer_list *t = list_first_entry(timers, struct cpu_timer_list, entry); - if (!--maxfire || tsk->se.sum_exec_runtime < t->expires.sched) { + unsigned long long runtime = task_sched_runtime(tsk, false); + if (!--maxfire || runtime < t->expires.sched) { tsk->cputime_expires.sched_exp = t->expires.sched; break; } -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists