linux-kernel - Re: [PATCH] drm: don't check modeset locks in panic handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 2 May 2013 22:45:11 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Daniel Vetter <daniel.vetter@...ll.ch>,
	DRI Development <dri-devel@...ts.freedesktop.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Dave Airlie <airlied@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH] drm: don't check modeset locks in panic handler

On Thu, May 02, 2013 at 12:13:08PM +0200, Borislav Petkov wrote:
> On Thu, May 02, 2013 at 09:43:05AM +0200, Daniel Vetter wrote:
> > Since we know that locking is broken in that case and it's more
> > important to not flood the dmesg with random gunk.
> > 
> > Cc: Dave Airlie <airlied@...il.com>
> > Cc: Borislav Petkov <bp@...en8.de>
> > References: https://groups.google.com/forum/?fromgroups=#!topic/linux.kernel/QFzFxSUeV4I
> 
> Yeah, we have this nice redirector service on k.org which uses the
> Message-ID only and doesn't rely on some external URLs remaining stable.
> You could use that instead:
> 
> Link: http://lkml.kernel.org/r/20130502000206.GH15623@pd.tnic
> 
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Daniel Vetter <daniel.vetter@...ll.ch>
> > ---
> >  drivers/gpu/drm/drm_crtc.c |    4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> > index 792c3e3..3be0802 100644
> > --- a/drivers/gpu/drm/drm_crtc.c
> > +++ b/drivers/gpu/drm/drm_crtc.c
> > @@ -78,6 +78,10 @@ void drm_warn_on_modeset_not_all_locked(struct drm_device *dev)
> >  {
> >  	struct drm_crtc *crtc;
> >  
> > +	/* Locking is currently fubar in the panic handler. */
> > +	if (oops_in_progress)
> > +		return;
> > +
> >  	list_for_each_entry(crtc, &dev->mode_config.crtc_list, head)
> >  		WARN_ON(!mutex_is_locked(&crtc->mutex));
> 
> Yep, thanks.
> 
> Reported-and-tested-by: Borislav Petkov <bp@...e.de>

Thanks for testing, patch applied to drm-intel-fixes.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/