linux-kernel - Re: [PATCH] Staging: Panel: panel: Fixed checkpatch line length warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 5 May 2013 16:06:40 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jake Champlin <jake.champlin.27@...il.com>
Cc:	willy@...a-x.org, gregkh@...uxfoundation.org,
	yamanetoshi@...il.com, adam.buchbinder@...il.com,
	peterhuewe@....de, fengguang.wu@...el.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: Panel: panel: Fixed checkpatch line length
 warnings

On Sat, May 04, 2013 at 11:21:17AM -0400, Jake Champlin wrote:
> @@ -1802,10 +1803,11 @@ static inline void input_state_falling(struct logical_input *input)
>  
>  			if (input->u.kbd.repeat_str[0]) {
>  				char *repeat_str = input->u.kbd.repeat_str;
> -				if (input->high_timer >= KEYPAD_REP_START)
> +				if (input->high_timer >= KEYPAD_REP_START) {
> +					int s = sizeof(input->u.kbd.repeat_str);
>  					input->high_timer -= KEYPAD_REP_DELAY;
> -					keypad_send_key(repeat_str,
> -							sizeof(input->u.kbd.repeat_str));
> +					keypad_send_key(repeat_str, s);
> +				}


This looks like a bugfix.  Good job.  Please mention bug fixes in
the changelog next time.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/