linux-kernel - Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 May 2013 13:32:25 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Fabio Baltieri <fabio.baltieri@...aro.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Lee Jones <lee.jones@...aro.org>,
	Ola Lilja <ola.o.lilja@...ricsson.com>
Subject: Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

On Wed, May 08, 2013 at 01:42:16PM +0200, Fabio Baltieri wrote:
> On Wed, May 08, 2013 at 11:51:24AM +0100, Mark Brown wrote:

> > I tend to agree with Lee that this looks like a bad approach - there's a
> > whole bunch of other code in there which I'd guess is probably equally
> > broken but only the pinctrl code is being removed.  Why not just fix it
> > (or better yet simplify all this stuff)?

> Sorry I did not get the subject, are you referring to other broken code
> in the ux500 driver or to pinctrl and shared pins in generals?

I'm saying that if functions like enable_msp() don't work reliably then
removing some but not all of their functionality isn't an obviously good
approach to fixing that.  Why does the other functionality work well but
not this bit?  It sounds like there's some reference counting bug here
is all...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)