| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 May 2013 22:40:26 +0800 From: Axel Lin <axel.lin@...ics.com> To: Lars-Peter Clausen <lars@...afoo.de> Cc: Jonathan Cameron <jic23@....ac.uk>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-iio@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH RFC] iio: dac: Fix build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m 2013/5/8 Lars-Peter Clausen <lars@...afoo.de>: > On 05/08/2013 10:36 AM, Axel Lin wrote: >> This patch fixes below build error when CONFIG_SPI_MASTER=y && CONFIG_I2C=m: >> >> drivers/built-in.o: In function `ad5064_i2c_write': >> drivers/iio/dac/ad5064.c:608: undefined reference to `i2c_master_send' >> drivers/built-in.o: In function `ad5064_i2c_register_driver': >> drivers/iio/dac/ad5064.c:646: undefined reference to `i2c_register_driver' >> drivers/built-in.o: In function `ad5064_i2c_unregister_driver': >> drivers/iio/dac/ad5064.c:651: undefined reference to `i2c_del_driver' >> make: *** [vmlinux] Error 1 >> >> Add config IIO_DAC_I2C_AND_SPI helper to handle such case: >> When CONFIG_I2C=m, meaning we can't build the drivers in with I2C support. >> Thus don't allow the drivers to be compiled as built-in. >> > > My plan was to do something like "depends on (SPI_MASTER && I2C!=m) || I2C", This change seems simpler than this path. Thus I'm going to send v2 for it. Thanks, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists